Bug 193844

Summary: Move logic from ChildProcess::setApplicationIsDaemon to NetworkProcess::initializeProcess
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, ap, bfulgham, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Alex Christensen 2019-01-25 13:41:23 PST 
Move logic from ChildProcess::setApplicationIsDaemon to NetworkProcess::initializeProcess
Comment 1 Alex Christensen 2019-01-25 13:42:07 PST 
Created attachment 360155 [details]
Patch
Comment 2 Andy Estes 2019-01-25 15:08:48 PST 
Comment on attachment 360155 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360155&action=review

> Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm:50
> +extern "C" OSStatus SetApplicationIsDaemon(Boolean isDaemon);

This should be in an SPI header.
Comment 3 Alex Christensen 2019-01-25 15:40:27 PST 
Created attachment 360178 [details]
Patch
Comment 4 Alex Christensen 2019-01-25 15:41:44 PST 
http://trac.webkit.org/r240520
Comment 5 Radar WebKit Bug Importer 2019-01-25 15:42:27 PST 
<rdar://problem/47564877>
Comment 6 Alexey Proskuryakov 2019-01-26 00:31:30 PST 
Comment on attachment 360178 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360178&action=review

> Source/WebKit/ChangeLog:8
> +        This simplifies ChildProcess and removes NetworkProcess-specific code from this generic abstraction.

The radar quoted as explanation of why this is needed in NetworkProcess is ancient. 

I’m guessing that we either need it in all child processes, or in none. Is it still doing anything useful in NetworkProcess? Does it even have a WindowServer connection before this call?