Bug 193814

Summary: Web Inspector: `WI.Setting.migrateValue` doesn't take into account the key prefix
Product: WebKit Reporter: Devin Rousso <drousso>
Component: Web InspectorAssignee: Devin Rousso <drousso>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, drousso, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Devin Rousso 2019-01-24 22:24:14 PST
All `WI.Setting` keys are prefixed with `com.apple.WebInspector`, followed by the inspection level, and finally the name of the setting.  `WI.Setting.migrateValue` doesn't take that into account, meaning that it doesn't actually read the key it's supposed to be taking the value from.
Comment 1 Devin Rousso 2019-01-24 22:26:22 PST
Created attachment 360082 [details]
Patch
Comment 2 Matt Baker 2019-01-25 11:09:41 PST
Comment on attachment 360082 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2019-01-25 11:35:35 PST
Comment on attachment 360082 [details]
Patch

Clearing flags on attachment: 360082

Committed r240487: <https://trac.webkit.org/changeset/240487>
Comment 4 WebKit Commit Bot 2019-01-25 11:35:36 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-01-25 11:36:28 PST
<rdar://problem/47556137>