Bug 193814 - Web Inspector: `WI.Setting.migrateValue` doesn't take into account the key prefix
Summary: Web Inspector: `WI.Setting.migrateValue` doesn't take into account the key pr...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
Keywords: InRadar
Depends on:
Reported: 2019-01-24 22:24 PST by Devin Rousso
Modified: 2019-01-25 11:36 PST (History)
5 users (show)

See Also:

Patch (2.59 KB, patch)
2019-01-24 22:26 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-01-24 22:24:14 PST
All `WI.Setting` keys are prefixed with `com.apple.WebInspector`, followed by the inspection level, and finally the name of the setting.  `WI.Setting.migrateValue` doesn't take that into account, meaning that it doesn't actually read the key it's supposed to be taking the value from.
Comment 1 Devin Rousso 2019-01-24 22:26:22 PST
Created attachment 360082 [details]
Comment 2 Matt Baker 2019-01-25 11:09:41 PST
Comment on attachment 360082 [details]

Comment 3 WebKit Commit Bot 2019-01-25 11:35:35 PST
Comment on attachment 360082 [details]

Clearing flags on attachment: 360082

Committed r240487: <https://trac.webkit.org/changeset/240487>
Comment 4 WebKit Commit Bot 2019-01-25 11:35:36 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-01-25 11:36:28 PST