RESOLVED FIXED 193814
Web Inspector: `WI.Setting.migrateValue` doesn't take into account the key prefix 
https://bugs.webkit.org/show_bug.cgi?id=193814
Summary Web Inspector: `WI.Setting.migrateValue` doesn't take into account the key pr...
Devin Rousso
Reported 2019-01-24 22:24:14 PST
All `WI.Setting` keys are prefixed with `com.apple.WebInspector`, followed by the inspection level, and finally the name of the setting. `WI.Setting.migrateValue` doesn't take that into account, meaning that it doesn't actually read the key it's supposed to be taking the value from.
Attachments
Patch (2.59 KB, patch)
2019-01-24 22:26 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-01-24 22:26:22 PST
Created attachment 360082 [details] Patch
Matt Baker
Comment 2 2019-01-25 11:09:41 PST
Comment on attachment 360082 [details] Patch r=me
WebKit Commit Bot
Comment 3 2019-01-25 11:35:35 PST
Comment on attachment 360082 [details] Patch Clearing flags on attachment: 360082 Committed r240487: <https://trac.webkit.org/changeset/240487>
WebKit Commit Bot
Comment 4 2019-01-25 11:35:36 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-01-25 11:36:28 PST
<rdar://problem/47556137>
Note You need to log in before you can comment on or make changes to this bug.