| Summary: | Remove usage of internal macro from private header | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, mark.lam, msaboff, saam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Keith Miller
2019-01-24 19:23:22 PST
Created attachment 360072 [details]
Patch
Attachment 360072 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/API/tests/testIncludes.m:36: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Can you fix the style issue? (In reply to Saam Barati from comment #3) > Can you fix the style issue? The style issue is that the public umbrella header should be included after our private headers but I'd rather include the public header first. Comment on attachment 360072 [details] Patch Clearing flags on attachment: 360072 Committed r240468: <https://trac.webkit.org/changeset/240468> All reviewed patches have been landed. Closing bug. |