Summary: | REGRESSION(?): Web Inspector: Can have multiple Timelines selected after edit mode | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||
Component: | Web Inspector | Assignee: | Matt Baker <mattbaker> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Joseph Pecoraro
2019-01-24 19:17:35 PST
Created attachment 360312 [details]
Patch
Comment on attachment 360312 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360312&action=review r=me, but I think we should write tests for patches that "fix a bug where...", so I'd like to see a test for this if possible > Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:350 > + treeOutline._selectionController.didRemoveItems(removedIndexes); I'd personally rather have the early-return happen inside `didRemoveItems`. Requiring the caller to know that you should only ever pass a non-null `WI.IndexSet` seems unnecessary, and is likely to be forgotten in the future. Also, should we also be early-returning if `!removedIndexes.size`? Created attachment 360359 [details]
Patch
Comment on attachment 360359 [details] Patch Clearing flags on attachment: 360359 Committed r240594: <https://trac.webkit.org/changeset/240594> All reviewed patches have been landed. Closing bug. |