Bug 193807

Summary: [LFC][BFC][MarginCollapsing] Refactor MarginCollapse::updateCollapsedMarginAfter
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Description zalan 2019-01-24 19:08:56 PST
just a small reshuffle.
Comment 1 zalan 2019-01-24 19:18:12 PST
Created attachment 360069 [details]
Patch
Comment 2 Simon Fraser (smfr) 2019-01-24 19:20:12 PST
Comment on attachment 360069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360069&action=review

> Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp:492
> +    // 7. No need to propagate to parent because its margin is not computed yet (estimated at most) 

Period at end
Comment 3 zalan 2019-01-24 20:14:39 PST
Committed r240467: <https://trac.webkit.org/changeset/240467>
Comment 4 Radar WebKit Bug Importer 2019-01-24 20:15:29 PST
<rdar://problem/47538539>