Bug 193807 - [LFC][BFC][MarginCollapsing] Refactor MarginCollapse::updateCollapsedMarginAfter
Summary: [LFC][BFC][MarginCollapsing] Refactor MarginCollapse::updateCollapsedMarginAfter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-01-24 19:08 PST by zalan
Modified: 2019-01-24 20:15 PST (History)
5 users (show)

See Also:

Attachments
Patch (9.42 KB, patch)
2019-01-24 19:18 PST, zalan 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-01-24 19:08:56 PST 
just a small reshuffle.
Comment 1 zalan 2019-01-24 19:18:12 PST 
Created attachment 360069 [details]
Patch
Comment 2 Simon Fraser (smfr) 2019-01-24 19:20:12 PST 
Comment on attachment 360069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360069&action=review

> Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp:492
> +    // 7. No need to propagate to parent because its margin is not computed yet (estimated at most) 

Period at end
Comment 3 zalan 2019-01-24 20:14:39 PST 
Committed r240467: <https://trac.webkit.org/changeset/240467>
Comment 4 Radar WebKit Bug Importer 2019-01-24 20:15:29 PST 
<rdar://problem/47538539>