Bug 193801

Summary: [JSC] RegExpConstructor should not have own IsoSubspace
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 193606    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews124 for ios-simulator-wk2
none
Patch
none
Patch mark.lam: review+

Yusuke Suzuki
Reported 2019-01-24 16:41:36 PST
We should extract per-JSGlobalObject data from RegExpConstructor, and put it in JSGlobalObject.
Attachments
Patch (25.40 KB, patch)
2019-01-26 01:10 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (72.81 KB, patch)
2019-01-27 01:08 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (73.48 KB, patch)
2019-01-27 01:33 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (74.84 KB, patch)
2019-01-27 01:45 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.45 MB, application/zip)
2019-01-27 06:54 PST, EWS Watchlist 		no flags
Details
Patch (74.84 KB, patch)
2019-01-27 11:15 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (74.98 KB, patch)
2019-01-27 11:25 PST, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-01-26 01:10:46 PST
Created attachment 360231 [details] Patch WIP
Yusuke Suzuki
Comment 2 2019-01-27 01:08:16 PST
Created attachment 360280 [details] Patch
Yusuke Suzuki
Comment 3 2019-01-27 01:33:56 PST
Created attachment 360282 [details] Patch
Yusuke Suzuki
Comment 4 2019-01-27 01:45:20 PST
Created attachment 360283 [details] Patch
EWS Watchlist
Comment 5 2019-01-27 06:54:26 PST
Comment on attachment 360283 [details] Patch Attachment 360283 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10911158 New failing tests: imported/w3c/web-platform-tests/webrtc/simplecall.https.html
EWS Watchlist
Comment 6 2019-01-27 06:54:28 PST
Created attachment 360295 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Yusuke Suzuki
Comment 7 2019-01-27 11:14:52 PST
(In reply to Build Bot from comment #6) > Created attachment 360295 [details] > Archive of layout-test-results from ews124 for ios-simulator-wk2 > > The attached test failures were seen while running run-webkit-tests on the > ios-sim-ews. > Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6 This is due to the test flakiness.
Yusuke Suzuki
Comment 8 2019-01-27 11:15:49 PST
Created attachment 360299 [details] Patch
Yusuke Suzuki
Comment 9 2019-01-27 11:25:16 PST
Created attachment 360301 [details] Patch
Mark Lam
Comment 10 2019-01-28 11:47:20 PST
Comment on attachment 360301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360301&action=review r=me > Source/JavaScriptCore/runtime/RegExpGlobalDataInlines.h:61 > +ALWAYS_INLINE MatchResult RegExpGlobalData::performMatch(VM& vm, JSGlobalObject* owner, RegExp* regExp, JSString* string, const String& input, int startOffset) nit: insert blank line before this.
Yusuke Suzuki
Comment 11 2019-01-28 11:50:05 PST
Comment on attachment 360301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360301&action=review >> Source/JavaScriptCore/runtime/RegExpGlobalDataInlines.h:61 >> +ALWAYS_INLINE MatchResult RegExpGlobalData::performMatch(VM& vm, JSGlobalObject* owner, RegExp* regExp, JSString* string, const String& input, int startOffset) > > nit: insert blank line before this. Nice, fixed.
Yusuke Suzuki
Comment 12 2019-01-28 11:52:22 PST
Committed r240593: <https://trac.webkit.org/changeset/240593>
Radar WebKit Bug Importer
Comment 13 2019-01-28 11:53:28 PST
<rdar://problem/47605248>
Note You need to log in before you can comment on or make changes to this bug.