Bug 193795
| Summary: | We should do constant folding on ValueOp even when it is UntypedUse | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Caio Lima <ticaiolima> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | saam |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 186173 | ||
Caio Lima
Right now, we don't do constant fold on ValueOp nodes, but there is no reason why we shouldn't do this, since profiling and prediction propagation can miss some opportunities.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Saam Barati
Yeah, the only thing we need to make sure of is that we don't fold away things that would've failed type checks. For UntypedUse that's obviously nothing. But for BigInt, we must make sure the inputs are BigInt.