Bug 193795

Summary: We should do constant folding on ValueOp even when it is UntypedUse
Product: WebKit Reporter: Caio Lima <ticaiolima>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 186173    

Description Caio Lima 2019-01-24 16:06:46 PST 
Right now, we don't do constant fold on ValueOp nodes, but there is no reason why we shouldn't do this, since profiling and prediction propagation can miss some opportunities.
Comment 1 Saam Barati 2019-01-24 16:27:26 PST 
Yeah, the only thing we need to make sure of is that we don't fold away things that would've failed type checks. For UntypedUse that's obviously nothing. But for BigInt, we must make sure the inputs are BigInt.