Bug 193790

Summary: Update Xcode projects with "Check .xcfilelists" build phase
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Tools / TestsAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, commit-queue, ews-watchlist, jeffm, keith_miller, lforschler, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Keith Rollin
Reported 2019-01-24 15:37:21 PST
Support for XCBuild includes specifying inputs and outputs to various Run Script build phases. These inputs and outputs are specified as .xcfilelist files. Once created, these .xcfilelist files need to be kept up-to-date. In order to check that they are up-to-date or not, add an Xcode build step that invokes an external script that performs the checking. If the .xcfilelists are found to be out-of-date, update them, halt the build, and instruct the developer to restart the build with up-to-date files. At this time, the checking and regenerating is performed only if the WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People who want to use this facility can set this variable and test out the checking/regenerating. Once it seems like there are no egregious issues that upset a developer's workflow, we'll unconditionally enable this facility.
Attachments
Patch (18.61 KB, patch)
2019-01-25 15:24 PST, Keith Rollin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Rollin
Comment 1 2019-01-24 15:39:12 PST
<rdar://problem/47201374>
Keith Rollin
Comment 2 2019-01-25 15:24:07 PST
Created attachment 360175 [details] Patch
WebKit Commit Bot
Comment 3 2019-01-25 15:52:57 PST
Comment on attachment 360175 [details] Patch Clearing flags on attachment: 360175 Committed r240525: <https://trac.webkit.org/changeset/240525>
WebKit Commit Bot
Comment 4 2019-01-25 15:52:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.