Bug 193787

Summary: [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, ews-watchlist, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ap: review+

Description Jonathan Bedard 2019-01-24 15:14:33 PST
Make iosSimulatorApplicationsPath more flexible to accommodate different runtime directories.
Comment 1 Jonathan Bedard 2019-01-24 15:14:45 PST
<rdar://problem/47497634>
Comment 2 Jonathan Bedard 2019-01-24 15:22:03 PST
Created attachment 360042 [details]
Patch
Comment 3 Alexey Proskuryakov 2019-01-24 16:01:29 PST
Comment on attachment 360042 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360042&action=review

> Tools/ChangeLog:3
> +        [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in it's path

s/it's/its/

> Tools/Scripts/webkitdirs.pm:2509
> +    my @runtimes = grep {!/^\./} readdir(RUNTIMES);

Maybe check for ".simruntime" in the name?

> Tools/Scripts/webkitdirs.pm:2511
> +    return File::Spec->catdir($runtimePath, @runtimes ? $runtimes[0] : "iOS.simruntime", "Contents", "Resources", "RuntimeRoot", "Applications");

I suggest adding a FIXME here. Building the path manually is fragile, and randomly picking a single runtime path is just weird. We need to find a way to determine which runtime corresponds to a simulator that we're about to use.
Comment 4 Jonathan Bedard 2019-01-24 16:35:21 PST
Committed r240455: <https://trac.webkit.org/changeset/240455>
Comment 5 Radar WebKit Bug Importer 2019-01-24 16:36:28 PST
<rdar://problem/47533806>