Bug 193784 – [iOS] Add logging of calls

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Per Arne Vollan]

We already do this on macOS, we should do it on iOS as well.

[Per Arne Vollan]

Created attachment 360041 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/47529440>

[Brent Fulgham]

Comment on attachment 360041 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360041&action=review

r=me, assuming you tested on shipping iOS to make sure it doesn't break test bots.

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:560
> +    (allow syscall-unix (with report))

Does this mean we will report, unless it is explicitly allowed below?

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 360041 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=360041&action=review
> 
> r=me, assuming you tested on shipping iOS to make sure it doesn't break test
> bots.
> 

I believe this is a low risk change, since we by default allow all calls.

> > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:560
> > +    (allow syscall-unix (with report))
> 
> Does this mean we will report, unless it is explicitly allowed below?

Yes. Thanks for reviewing!

[WebKit Commit Bot]

Comment on attachment 360041 [details]
Patch

Clearing flags on attachment: 360041

Committed r240478: <https://trac.webkit.org/changeset/240478>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.