Bug 193784

Summary: [iOS] Add logging of calls
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: iPhone / iPad   
OS: All   
Attachments:
Description Flags
Patch none

Description Per Arne Vollan 2019-01-24 14:42:34 PST
We already do this on macOS, we should do it on iOS as well.
Comment 1 Per Arne Vollan 2019-01-24 14:44:30 PST
Created attachment 360041 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-01-24 14:46:28 PST
<rdar://problem/47529440>
Comment 3 Brent Fulgham 2019-01-25 09:22:18 PST
Comment on attachment 360041 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360041&action=review

r=me, assuming you tested on shipping iOS to make sure it doesn't break test bots.

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:560
> +    (allow syscall-unix (with report))

Does this mean we will report, unless it is explicitly allowed below?
Comment 4 Per Arne Vollan 2019-01-25 09:27:34 PST
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 360041 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=360041&action=review
> 
> r=me, assuming you tested on shipping iOS to make sure it doesn't break test
> bots.
> 

I believe this is a low risk change, since we by default allow all calls.

> > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:560
> > +    (allow syscall-unix (with report))
> 
> Does this mean we will report, unless it is explicitly allowed below?

Yes. Thanks for reviewing!
Comment 5 WebKit Commit Bot 2019-01-25 09:59:03 PST
Comment on attachment 360041 [details]
Patch

Clearing flags on attachment: 360041

Committed r240478: <https://trac.webkit.org/changeset/240478>
Comment 6 WebKit Commit Bot 2019-01-25 09:59:04 PST
All reviewed patches have been landed.  Closing bug.