RESOLVED FIXED193784
[iOS] Add logging of calls 
https://bugs.webkit.org/show_bug.cgi?id=193784
Summary [iOS] Add logging of calls
Per Arne Vollan
Reported 2019-01-24 14:42:34 PST
We already do this on macOS, we should do it on iOS as well.
Attachments
Patch (6.29 KB, patch)
2019-01-24 14:44 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2019-01-24 14:44:30 PST
Created attachment 360041 [details] Patch
Radar WebKit Bug Importer
Comment 2 2019-01-24 14:46:28 PST
<rdar://problem/47529440>
Brent Fulgham
Comment 3 2019-01-25 09:22:18 PST
Comment on attachment 360041 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360041&action=review r=me, assuming you tested on shipping iOS to make sure it doesn't break test bots. > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:560 > + (allow syscall-unix (with report)) Does this mean we will report, unless it is explicitly allowed below?
Per Arne Vollan
Comment 4 2019-01-25 09:27:34 PST
(In reply to Brent Fulgham from comment #3) > Comment on attachment 360041 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=360041&action=review > > r=me, assuming you tested on shipping iOS to make sure it doesn't break test > bots. > I believe this is a low risk change, since we by default allow all calls. > > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:560 > > + (allow syscall-unix (with report)) > > Does this mean we will report, unless it is explicitly allowed below? Yes. Thanks for reviewing!
WebKit Commit Bot
Comment 5 2019-01-25 09:59:03 PST
Comment on attachment 360041 [details] Patch Clearing flags on attachment: 360041 Committed r240478: <https://trac.webkit.org/changeset/240478>
WebKit Commit Bot
Comment 6 2019-01-25 09:59:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.