Bug 193783

Summary: Fix missing dependencies in extract-dependencies-from-makefile
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Tools / TestsAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, commit-queue, jeffm, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Keith Rollin 2019-01-24 14:28:07 PST
The extract-dependencies-from-makefile script generates .xcfilelists for XCBuild by invoking a makefile in --debug mode, parsing the dependency information in the output, and extracting information regarding targets and dependents. However, the way `make` emits this dependency information is not rigorous, and so we need to determine what lines to look for and parse by trial and error. This approach didn't catch all the information we needed to collect, so update the script to look for the additional lines we now know to look for.

rdar://problem/47201571
Comment 1 Keith Rollin 2019-01-24 16:50:11 PST
Created attachment 360052 [details]
Patch
Comment 2 WebKit Commit Bot 2019-01-25 13:51:08 PST
Comment on attachment 360052 [details]
Patch

Clearing flags on attachment: 360052

Committed r240503: <https://trac.webkit.org/changeset/240503>
Comment 3 WebKit Commit Bot 2019-01-25 13:51:10 PST
All reviewed patches have been landed.  Closing bug.