Bug 193782

Summary: Complete the implementation of generate-xcfilelists
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Tools / TestsAssignee: Keith Rollin <krollin>
Severity: Normal CC: achristensen, ap, commit-queue, jeffm, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Keith Rollin 2019-01-24 14:20:20 PST
A preliminary version of generate-xcfilelists was added in r238008. It needs to be updated in order to:

* Support checking of .xcfilelists
* Perform better execution of `make DerivedSources.make` by relaunching generate-xcfilelists under xcodebuild
* Support incremental generation and checking of .xcfilelists
* Support supplementary .xcfilelists files from WebKitAdditions
* Support being wrapped by parallel version of generate-xcfilelists in Internal that adds support for (re)generating WebKit projects in that repo.
* Support builds that have been performed in WebKitBuild as well as ~/Library/Developer/code/DerivedData
* Increase robustness and debugging facilities.

Comment 1 Keith Rollin 2019-01-24 16:49:24 PST
Created attachment 360051 [details]
Comment 2 Alex Christensen 2019-01-25 13:48:22 PST
Comment on attachment 360051 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=360051&action=review

Nothing jumps out as horribly wrong.

> Tools/Scripts/generate-xcfilelists:1
> +#!/bin/bash

Comment 3 Keith Rollin 2019-01-25 13:54:12 PST
As opposed to /bin/sh? We effectively use bash features in our other scripts that say /bin/sh, so I figured be clear about it. Also, it helps with my editor's highlighting if it knows that this is bash code and not plain old sh.

Or as opposed to Python/Perl/Ruby? I guess I started in bash and got carried away.
Comment 4 Alex Christensen 2019-01-25 13:55:06 PST
(In reply to Keith Rollin from comment #3)
> Or as opposed to Python/Perl/Ruby? I guess I started in bash and got carried
> away.
Seriously.  You should've used the most elegant language, which is of course Perl.
Comment 5 WebKit Commit Bot 2019-01-25 14:24:00 PST
Comment on attachment 360051 [details]

Clearing flags on attachment: 360051

Committed r240510: <https://trac.webkit.org/changeset/240510>
Comment 6 WebKit Commit Bot 2019-01-25 14:24:01 PST
All reviewed patches have been landed.  Closing bug.