Summary: | Complete the implementation of generate-xcfilelists | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keith Rollin <krollin> | ||||
Component: | Tools / Tests | Assignee: | Keith Rollin <krollin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, ap, commit-queue, jeffm, lforschler, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Keith Rollin
2019-01-24 14:20:20 PST
Created attachment 360051 [details]
Patch
Comment on attachment 360051 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360051&action=review Nothing jumps out as horribly wrong. > Tools/Scripts/generate-xcfilelists:1 > +#!/bin/bash bash?!?! As opposed to /bin/sh? We effectively use bash features in our other scripts that say /bin/sh, so I figured be clear about it. Also, it helps with my editor's highlighting if it knows that this is bash code and not plain old sh. Or as opposed to Python/Perl/Ruby? I guess I started in bash and got carried away. (In reply to Keith Rollin from comment #3) > Or as opposed to Python/Perl/Ruby? I guess I started in bash and got carried > away. Seriously. You should've used the most elegant language, which is of course Perl. Comment on attachment 360051 [details] Patch Clearing flags on attachment: 360051 Committed r240510: <https://trac.webkit.org/changeset/240510> All reviewed patches have been landed. Closing bug. |