Bug 193762

Summary: Need a mechanism to override navigator.userAgent
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: WebKit2Assignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, bfulgham, cdumez, dbates, ews-watchlist, ggaren, japhet, rniwa, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=193950
Attachments:
Description Flags
WIP
none
Adds a mechanism
none
Added another test case
bfulgham: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews107 for mac-highsierra-wk2 none

Ryosuke Niwa
Reported 2019-01-23 21:38:35 PST
We need a mechanism to override user agent string just for navigator.userAgent without affecting UA string we send to the server.
Attachments
WIP (9.82 KB, patch)
2019-01-23 21:40 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Adds a mechanism (16.14 KB, patch)
2019-01-25 00:00 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Added another test case (18.09 KB, patch)
2019-01-25 20:24 PST, Ryosuke Niwa 		bfulgham: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews107 for mac-highsierra-wk2 (3.20 MB, application/zip)
2019-01-25 21:41 PST, EWS Watchlist 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-01-23 21:38:59 PST
<rdar://problem/47504939>
Ryosuke Niwa
Comment 2 2019-01-23 21:40:23 PST
Created attachment 359993 [details] WIP
Ryosuke Niwa
Comment 3 2019-01-25 00:00:20 PST
Created attachment 360088 [details] Adds a mechanism
Ryosuke Niwa
Comment 4 2019-01-25 18:42:25 PST
Ping reviewers.
Brent Fulgham
Comment 5 2019-01-25 18:52:06 PST
Comment on attachment 360088 [details] Adds a mechanism Could the test confirm that we get standard WebKit UA in headers, instead of using two custom user agents? Otherwise, looks good, but I think a loader person should give a final sign-off.
Ryosuke Niwa
Comment 6 2019-01-25 19:29:46 PST
(In reply to Brent Fulgham from comment #5) > Comment on attachment 360088 [details] > Adds a mechanism > > Could the test confirm that we get standard WebKit UA in headers, instead of > using two custom user agents? I guess I can add another test for that.
Ryosuke Niwa
Comment 7 2019-01-25 20:24:10 PST
Created attachment 360217 [details] Added another test case
Brent Fulgham
Comment 8 2019-01-25 20:32:57 PST
Comment on attachment 360217 [details] Added another test case Looks great! r=me
EWS Watchlist
Comment 9 2019-01-25 21:41:02 PST
Comment on attachment 360217 [details] Added another test case Attachment 360217 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10897704 New failing tests: http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html
EWS Watchlist
Comment 10 2019-01-25 21:41:03 PST
Created attachment 360223 [details] Archive of layout-test-results from ews107 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Ryosuke Niwa
Comment 11 2019-01-25 22:51:01 PST
Committed r240541: <https://trac.webkit.org/changeset/240541>
Note You need to log in before you can comment on or make changes to this bug.