Bug 193745

Summary:

[iOS] Enable media element volume on iPad

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, jer.noble, jonlee, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Eric Carlson 2019-01-23 16:11:46 PST

Enable media element volume on iPad

Comment 1 Eric Carlson 2019-01-23 16:12:17 PST

<rdar://problem/47452297>

Comment 2 Eric Carlson 2019-01-23 16:20:55 PST

Created attachment 359969 [details]
Patch

Comment 3 Jon Lee 2019-01-23 16:29:12 PST

Comment on attachment 359969 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359969&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:5341
> +

Why shouldn't this be preserved if not iPad?

Comment 4 WebKit Commit Bot 2019-01-24 07:31:07 PST

Comment on attachment 359969 [details]
Patch

Clearing flags on attachment: 359969

Committed r240434: <https://trac.webkit.org/changeset/240434>

Comment 5 WebKit Commit Bot 2019-01-24 07:31:09 PST

All reviewed patches have been landed.  Closing bug.