Bug 193736

Summary: [css-grid] Flaky tests from bug 193657
Product: WebKit Reporter: Oriol Brufau <obrufau>
Component: CSSAssignee: Oriol Brufau <obrufau>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, rego, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 193657    
Attachments:
Description Flags
Patch none

Description Oriol Brufau 2019-01-23 12:55:06 PST 
Bug 193657 imported various WPT tests. Some still had failures due to bug 189513 and bug 193656.
However, it seems that the exact failures are flaky, e.g.
https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r240334%20(9001)/results.html
https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r240333%20(9000)/results.html
This is making the tree red.
Comment 1 Oriol Brufau 2019-01-23 13:04:38 PST 
Created attachment 359934 [details]
Patch
Comment 2 WebKit Commit Bot 2019-01-23 14:16:00 PST 
Comment on attachment 359934 [details]
Patch

Clearing flags on attachment: 359934

Committed r240362: <https://trac.webkit.org/changeset/240362>
Comment 3 WebKit Commit Bot 2019-01-23 14:16:01 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-01-23 14:16:28 PST 
<rdar://problem/47493645>
Comment 5 Oriol Brufau 2019-01-24 08:51:22 PST 
Locally I can reproduce the flakiness with WPE but not with GTK.
However, if I add `body { overflow: scroll; }` to the tests, so that layout is only done once, then they seem to always pass in WPE too.