Bug 193708

Summary: Minor improvements to NetworkProcess
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKit2Assignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch achristensen: review+

Description Michael Catanzaro 2019-01-22 21:39:04 PST 
I spent a lot of time looking at NetworkProcess.cpp today and found a couple minor things to improve.
Comment 1 Michael Catanzaro 2019-01-22 21:41:28 PST 
Created attachment 359851 [details]
Patch
Comment 2 Alex Christensen 2019-01-23 10:58:36 PST 
Comment on attachment 359851 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359851&action=review

Cool

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:539
> +        platformCreateDefaultStorageSession();
> +        ASSERT(m_defaultNetworkStorageSession);

This would be more obvious if it were m_defaultNetworkStorageSession = platformCreateDefaultStorageSession();
Comment 3 Michael Catanzaro 2019-01-23 11:02:16 PST 
(In reply to Alex Christensen from comment #2)
> This would be more obvious if it were m_defaultNetworkStorageSession =
> platformCreateDefaultStorageSession();

Yes indeed, I'll land it that way.
Comment 4 Michael Catanzaro 2019-01-23 11:19:02 PST 
Committed r240350: <https://trac.webkit.org/changeset/240350>
Comment 5 Radar WebKit Bug Importer 2019-01-23 11:20:29 PST 
<rdar://problem/47487277>