Bug 193689

Summary: [ARM] Check for negative zero instead of just zero
Product: WebKit Reporter: Dominik Inführ <dominik.infuehr>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, guijemont, guijemont+jsc-armv7-ews, keith_miller, mark.lam, msaboff, rniwa, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews105 for mac-highsierra-wk2
none
Patch none

Dominik Inführ
Reported 2019-01-22 15:13:34 PST
[ARM] Check for negative zero instead of just zero
Attachments
Patch (1.98 KB, patch)
2019-01-22 15:16 PST, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews105 for mac-highsierra-wk2 (3.15 MB, application/zip)
2019-01-22 16:40 PST, EWS Watchlist 		no flags
Details
Patch (2.65 KB, patch)
2019-01-23 03:24 PST, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dominik Inführ
Comment 1 2019-01-22 15:16:55 PST
Created attachment 359788 [details] Patch
EWS Watchlist
Comment 2 2019-01-22 16:40:27 PST
Comment on attachment 359788 [details] Patch Attachment 359788 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10846835 New failing tests: imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html
EWS Watchlist
Comment 3 2019-01-22 16:40:28 PST
Created attachment 359807 [details] Archive of layout-test-results from ews105 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Dominik Inführ
Comment 4 2019-01-23 03:24:54 PST
Created attachment 359866 [details] Patch
Mark Lam
Comment 5 2019-01-23 11:49:12 PST
Comment on attachment 359866 [details] Patch r=me. Is there already a test that verifies that -0 compares work correctly? I think there probably is, but if you not, can you add one?
Dominik Inführ
Comment 6 2019-01-24 02:31:45 PST
Hi, thanks for the review! I've thought about writing tests, but there seemed to be enough tests: JSTests/stress/math-(floor|trunc|round|ceil)-basics.js, JSTests/stress/op_div_<something> and JSTests/stress/arith-(round|floor|ceil|trunc)-on-various-types.js.
WebKit Commit Bot
Comment 7 2019-01-29 02:41:33 PST
Comment on attachment 359866 [details] Patch Clearing flags on attachment: 359866 Committed r240650: <https://trac.webkit.org/changeset/240650>
WebKit Commit Bot
Comment 8 2019-01-29 02:41:34 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-01-29 02:42:30 PST
<rdar://problem/47627879>
Note You need to log in before you can comment on or make changes to this bug.