| Summary: | Adding a child to a ScrollingStateNode needs to trigger a tree state commit | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | cmarcelo, ews-watchlist, fred.wang, jamesr, koivisto, luiz, rniwa, simon.fraser, tonikitoo, webkit-bug-importer, zalan | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Simon Fraser (smfr)
2019-01-22 13:49:15 PST
Created attachment 359771 [details]
Patch
Created attachment 359774 [details]
Patch
Comment on attachment 359774 [details] Patch Attachment 359774 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10845206 New failing tests: scrollingcoordinator/lose-scrolling-node-parent.html scrollingcoordinator/gain-scrolling-node-parent.html Created attachment 359784 [details]
Archive of layout-test-results from ews101 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Those tests should not run in WK1 (bug 193690). Comment on attachment 359774 [details] Patch Attachment 359774 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10846000 New failing tests: scrollingcoordinator/lose-scrolling-node-parent.html scrollingcoordinator/gain-scrolling-node-parent.html Created attachment 359801 [details]
Archive of layout-test-results from ews117 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 359774 [details] Patch Attachment 359774 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/10848279 New failing tests: scrollingcoordinator/lose-scrolling-node-parent.html scrollingcoordinator/gain-scrolling-node-parent.html Created attachment 359824 [details]
Archive of layout-test-results from ews205 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 359774 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359774&action=review > LayoutTests/scrollingcoordinator/gain-scrolling-node-parent.html:4 > + <title>Check that scrolling nodes get reparented when an ancestor is removed</title> I'm confused by the file name, title and #target going from scroll to visible. I think two last are not what you wanted to do, right? > LayoutTests/scrollingcoordinator/gain-scrolling-node-parent.html:14 > + function doTest() { nit: the brace should be on the next line > LayoutTests/scrollingcoordinator/lose-scrolling-node-parent.html:14 > + function doTest() { Ditto. |