Bug 193668

Summary: [iOS] Flash when swiping back to Google search result page
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, ews-watchlist, ggaren, rniwa, simon.fraser, thorton, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
Archive of layout-test-results from ews106 for mac-highsierra-wk2 none

Antti Koivisto
Reported 2019-01-22 06:54:30 PST
If the google page is scrolled, there is sometimes a short flash.
Attachments
patch (4.33 KB, patch)
2019-01-22 07:15 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.69 MB, application/zip)
2019-01-22 08:08 PST, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-01-22 06:54:51 PST
<rdar://problem/47071684>
Antti Koivisto
Comment 2 2019-01-22 07:15:04 PST
Created attachment 359733 [details] patch
EWS Watchlist
Comment 3 2019-01-22 08:08:18 PST
Comment on attachment 359733 [details] patch Attachment 359733 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10839122 New failing tests: imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html
EWS Watchlist
Comment 4 2019-01-22 08:08:20 PST
Created attachment 359736 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Geoffrey Garen
Comment 5 2019-01-22 11:39:37 PST
Comment on attachment 359733 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=359733&action=review Crash seems unrelated: imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html [ Crash ] > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:349 > + m_hasRestoredExposedContentRectAfterDidCommitLoad = true; Do we need to set this back to false at some point?
Antti Koivisto
Comment 6 2019-01-22 12:06:35 PST
Comment on attachment 359733 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=359733&action=review > Source/WebKit/WebProcess/WebPage/WebPage.cpp:5607 > + m_hasRestoredExposedContentRectAfterDidCommitLoad = false; Right here.
Geoffrey Garen
Comment 7 2019-01-22 13:01:49 PST
Comment on attachment 359733 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=359733&action=review >> Source/WebKit/WebProcess/WebPage/WebPage.cpp:5607 >> + m_hasRestoredExposedContentRectAfterDidCommitLoad = false; > > Right here. LOL, not sure how I missed this.
WebKit Commit Bot
Comment 8 2019-01-22 14:31:43 PST
Comment on attachment 359733 [details] patch Clearing flags on attachment: 359733 Committed r240298: <https://trac.webkit.org/changeset/240298>
WebKit Commit Bot
Comment 9 2019-01-22 14:31:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.