Bug 193661

Summary: [JSC] Intl constructors should fit in sizeof(InternalFunction)
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, mark.lam, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 193606    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews102 for mac-highsierra
none
Patch
none
Patch
none
Patch mark.lam: review+

Yusuke Suzuki
Reported 2019-01-21 16:18:23 PST
[JSC] Intl constructors should fit to sizeof(InternalFunction)
Attachments
Patch (44.48 KB, patch)
2019-01-21 16:25 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-highsierra (2.52 MB, application/zip)
2019-01-21 17:31 PST, EWS Watchlist 		no flags
Details
Patch (46.80 KB, patch)
2019-01-21 17:35 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (44.75 KB, patch)
2019-01-21 17:37 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (44.83 KB, patch)
2019-01-21 19:00 PST, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-01-21 16:25:39 PST
Created attachment 359710 [details] Patch
Yusuke Suzuki
Comment 2 2019-01-21 16:27:27 PST
Currently, we do not have the good way handling ENABLE(INTL) in our create_hash_table script. But in the future, we can make IntlObject lazily-initialized too.
EWS Watchlist
Comment 3 2019-01-21 17:31:18 PST
Comment on attachment 359710 [details] Patch Attachment 359710 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10833541 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 4 2019-01-21 17:31:19 PST
Created attachment 359714 [details] Archive of layout-test-results from ews102 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-highsierra Platform: Mac OS X 10.13.6
Yusuke Suzuki
Comment 5 2019-01-21 17:35:12 PST
Created attachment 359715 [details] Patch
Yusuke Suzuki
Comment 6 2019-01-21 17:37:15 PST
Created attachment 359716 [details] Patch
Yusuke Suzuki
Comment 7 2019-01-21 19:00:12 PST
Created attachment 359717 [details] Patch
Mark Lam
Comment 8 2019-01-22 11:11:05 PST
Comment on attachment 359717 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359717&action=review r=me > Source/JavaScriptCore/ChangeLog:14 > + This patchh also includes the preparation for making Intl properties lazy. But currently it is not possible since @Collator reference exists typo: /patchh/patch/.
Yusuke Suzuki
Comment 9 2019-01-22 11:16:23 PST
Comment on attachment 359717 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359717&action=review >> Source/JavaScriptCore/ChangeLog:14 >> + This patchh also includes the preparation for making Intl properties lazy. But currently it is not possible since @Collator reference exists > > typo: /patchh/patch/. Nice! Fixed.
Yusuke Suzuki
Comment 10 2019-01-22 12:33:42 PST
Committed r240273: <https://trac.webkit.org/changeset/240273>
Radar WebKit Bug Importer
Comment 11 2019-01-22 12:34:42 PST
<rdar://problem/47455898>
Yusuke Suzuki
Comment 12 2019-01-22 21:59:47 PST
~1% improvement in RAMification.
Note You need to log in before you can comment on or make changes to this bug.