| Summary: | [JSC] Intl constructors should fit in sizeof(InternalFunction) | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | ews-watchlist, mark.lam, rniwa, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 193606 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Yusuke Suzuki
2019-01-21 16:18:23 PST
Created attachment 359710 [details]
Patch
Currently, we do not have the good way handling ENABLE(INTL) in our create_hash_table script. But in the future, we can make IntlObject lazily-initialized too. Comment on attachment 359710 [details] Patch Attachment 359710 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10833541 Number of test failures exceeded the failure limit. Created attachment 359714 [details]
Archive of layout-test-results from ews102 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 359715 [details]
Patch
Created attachment 359716 [details]
Patch
Created attachment 359717 [details]
Patch
Comment on attachment 359717 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359717&action=review r=me > Source/JavaScriptCore/ChangeLog:14 > + This patchh also includes the preparation for making Intl properties lazy. But currently it is not possible since @Collator reference exists typo: /patchh/patch/. Comment on attachment 359717 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359717&action=review >> Source/JavaScriptCore/ChangeLog:14 >> + This patchh also includes the preparation for making Intl properties lazy. But currently it is not possible since @Collator reference exists > > typo: /patchh/patch/. Nice! Fixed. Committed r240273: <https://trac.webkit.org/changeset/240273> ~1% improvement in RAMification. |