Bug 193660

Summary:	REGRESSION (r240243): Caused an API tests to fail
Product:	WebKit	Reporter:	Brent Fulgham <bfulgham>
Component:	WebKit Misc.	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ap, bfulgham, mcatanzaro, ryanhaddad, tsavell, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:	193556
Bug Blocks:

Description Brent Fulgham 2019-01-21 15:50:11 PST

Correct an API test failure introduced by my changes in r240243.

Comment 1 Radar WebKit Bug Importer 2019-01-21 15:50:42 PST

<rdar://problem/47433602>

Comment 2 Brent Fulgham 2019-01-21 17:41:13 PST

My original patch was incrementing the pending callback count before deciding if a callback was actually needed. This left it out of balance, preventing the callback from ever firing.

Comment 3 Brent Fulgham 2019-01-21 17:55:55 PST

Committed r240247: <https://trac.webkit.org/changeset/240247>

Comment 4 Alexey Proskuryakov 2019-01-22 09:29:41 PST

Yay tests!

Comment 5 Brent Fulgham 2019-01-22 09:34:14 PST

(In reply to Alexey Proskuryakov from comment #4)
> Yay tests!

And for actually paying attention to them! :-)

Comment 6 Michael Catanzaro 2019-01-22 16:32:30 PST

Committed r240308: <https://trac.webkit.org/changeset/240308>