Bug 193644

Summary: DFG: When inlining DataView set* intrinsics we need to set undefined as our result
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, ews-watchlist, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Description Saam Barati 2019-01-20 20:12:51 PST 
....
Comment 1 Saam Barati 2019-01-20 20:14:24 PST 
<rdar://problem/46209745>
Comment 2 Saam Barati 2019-01-20 20:39:47 PST 
Created attachment 359668 [details]
patch
Comment 3 EWS Watchlist 2019-01-20 20:41:13 PST 
Attachment 359668 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:2144:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:2185:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Yusuke Suzuki 2019-01-20 21:19:42 PST 
Comment on attachment 359668 [details]
patch

r=me
Comment 5 WebKit Commit Bot 2019-01-20 22:13:14 PST 
Comment on attachment 359668 [details]
patch

Clearing flags on attachment: 359668

Committed r240229: <https://trac.webkit.org/changeset/240229>
Comment 6 WebKit Commit Bot 2019-01-20 22:13:15 PST 
All reviewed patches have been landed.  Closing bug.