Bug 193644

Summary: DFG: When inlining DataView set* intrinsics we need to set undefined as our result
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, ews-watchlist, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Saam Barati
Reported 2019-01-20 20:12:51 PST
....
Attachments
patch (102.22 KB, patch)
2019-01-20 20:39 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-01-20 20:14:24 PST
<rdar://problem/46209745>
Saam Barati
Comment 2 2019-01-20 20:39:47 PST
Created attachment 359668 [details] patch
EWS Watchlist
Comment 3 2019-01-20 20:41:13 PST
Attachment 359668 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:2144: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:2185: Non-label code inside switch statements should be indented. [whitespace/indent] [4] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 4 2019-01-20 21:19:42 PST
Comment on attachment 359668 [details] patch r=me
WebKit Commit Bot
Comment 5 2019-01-20 22:13:14 PST
Comment on attachment 359668 [details] patch Clearing flags on attachment: 359668 Committed r240229: <https://trac.webkit.org/changeset/240229>
WebKit Commit Bot
Comment 6 2019-01-20 22:13:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.