Bug 19363

Summary: Compiler error in Entity.h
Product: WebKit Reporter: Alexander Vassilev <avasilev>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Severity: Major    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Description Flags
proposed temporary fix ap: review+

Description Alexander Vassilev 2008-06-02 15:34:31 PDT
Compiling WebKit with MINGW, cygwin environment.
Compiler says that class Entity has a default constructor but its base class ContainerNode doesn't have a default constructor. From what I found the Entity class is there only for compatibility, so I made a temporary fix with teh attached patch, but I hope someone competent can solve the problem the right way.
Comment 1 Alexander Vassilev 2008-06-02 15:36:24 PDT
Created attachment 21470 [details]
proposed temporary fix
Comment 2 Alexey Proskuryakov 2008-06-03 00:56:51 PDT
Comment on attachment 21470 [details]
proposed temporary fix

I think that this is basically the right fix. I'll land it with some modifications.

+    Entity(): ContainerNode(0){};

We'd write this as

+    Entity() : ContainerNode(0) {}

Also, the constructor should be private for clarity.
Comment 3 Alexey Proskuryakov 2008-06-03 00:57:59 PDT
Fixed in <http://trac.webkit.org/changeset/34336>.