Bug 193554

Summary: A track source should be unmuted whenever reenabled after setDirection changes
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description youenn fablet 2019-01-17 15:15:01 PST
A track source should be unmuted whenever reenabled after setDirection changes
Comment 1 Radar WebKit Bug Importer 2019-01-17 15:15:28 PST
<rdar://problem/47366196>
Comment 2 youenn fablet 2019-01-17 16:53:49 PST
Created attachment 359426 [details]
Patch
Comment 3 Eric Carlson 2019-01-17 21:15:58 PST
Comment on attachment 359426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359426&action=review

> LayoutTests/webrtc/video-setDirection.html:100
> +        assert_equals(stream, video.srcObject);

Why does this fail?
Comment 4 youenn fablet 2019-01-18 08:52:45 PST
(In reply to Eric Carlson from comment #3)
> Comment on attachment 359426 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=359426&action=review
> 
> > LayoutTests/webrtc/video-setDirection.html:100
> > +        assert_equals(stream, video.srcObject);
> 
> Why does this fail?

Libwebrtc tell us that the media stream is gone (through OnRemoveStream) so we remove it and recreate it later on.

We should probably keep a weak of the MediaStream instead.
If still there, we could then reuse it.
Otherwise, recreating a new one would be unobservable.
Comment 5 WebKit Commit Bot 2019-01-18 09:19:31 PST
Comment on attachment 359426 [details]
Patch

Clearing flags on attachment: 359426

Committed r240152: <https://trac.webkit.org/changeset/240152>
Comment 6 WebKit Commit Bot 2019-01-18 09:19:33 PST
All reviewed patches have been landed.  Closing bug.