Bug 193510

Summary: Add infrastructure to enable/disable ITP Debug Mode through Preferences
Product: WebKit Reporter: John Wilander <wilander>
Component: WebKit2Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dino, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

John Wilander
Reported 2019-01-16 14:54:37 PST
We need some infrastructure to allow the hosting app to turn on ITP Debug Mode.
Attachments
Patch (11.33 KB, patch)
2019-01-17 11:00 PST, John Wilander 		no flags
DetailsFormatted DiffDiff
Patch (11.36 KB, patch)
2019-01-17 11:17 PST, John Wilander 		no flags
DetailsFormatted DiffDiff
Patch (13.45 KB, patch)
2019-01-17 12:11 PST, John Wilander 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-01-16 14:55:27 PST
<rdar://problem/47330969>
John Wilander
Comment 2 2019-01-17 11:00:59 PST
Created attachment 359391 [details] Patch
John Wilander
Comment 3 2019-01-17 11:17:17 PST
Created attachment 359393 [details] Patch
John Wilander
Comment 4 2019-01-17 11:17:41 PST
Fixed the WPE build error.
John Wilander
Comment 5 2019-01-17 12:11:36 PST
Created attachment 359402 [details] Patch
John Wilander
Comment 6 2019-01-17 12:11:52 PST
Fixed the test failure.
John Wilander
Comment 7 2019-01-17 13:16:45 PST
The mac-wk2 bot seems to be in bad shape. The test failures are unrelated to this patch.
Dean Jackson
Comment 8 2019-01-17 13:20:40 PST
Comment on attachment 359402 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359402&action=review > Source/WebCore/ChangeLog:13 > + (WebCore::RuntimeEnabledFeatures::setItpDebugModeEnabled): > + (WebCore::RuntimeEnabledFeatures::itpDebugModeEnabled const): Why not capitalise ITP?
John Wilander
Comment 9 2019-01-17 13:26:28 PST
(In reply to Dean Jackson from comment #8) > Comment on attachment 359402 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=359402&action=review > > > Source/WebCore/ChangeLog:13 > > + (WebCore::RuntimeEnabledFeatures::setItpDebugModeEnabled): > > + (WebCore::RuntimeEnabledFeatures::itpDebugModeEnabled const): > > Why not capitalise ITP? I started out that way but it lead to all kinds of ugliness in generated code. Maybe I backed out most of that stuff but generally, vanilla camel casing works best.
John Wilander
Comment 10 2019-01-17 13:26:48 PST
Thanks for the review, Dean!
WebKit Commit Bot
Comment 11 2019-01-17 13:36:54 PST
Comment on attachment 359402 [details] Patch Clearing flags on attachment: 359402 Committed r240129: <https://trac.webkit.org/changeset/240129>
WebKit Commit Bot
Comment 12 2019-01-17 13:36:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.