Bug 193501

Summary: Web Inspector: Fix TreeOutline TypeError:​ this._indexesForSubtree is not a function
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, nvasilyev, webkit-bug-importer
Priority: P1 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Matt Baker 2019-01-16 11:40:53 PST 
This bug was introduced in https://webkit.org/b/192917.

Steps to Reproduce:
1. Inspect daringfireball.net
2. Open Elements tab
3. Reload the page

TypeError:​ this._indexesForSubtree is not a function. (In 'this._indexesForSubtree(child)​', 'this._indexesForSubtree' is undefined)​ (at TreeOutline.js:​332:​53)​
    removeChildAtIndex @ TreeOutline.js:​332:​53
    _updateChildren @ DOMTreeElement.js:​494:​36
    _updateChildren @ [native code]​
    getChildNodes @ DOMNode.js:​490:​25
    updateChildren @ DOMTreeElement.js:​420:​45
    _updateModifiedNodes @ DOMTreeUpdater.js:​125:​49
    performWork @ Utilities.js:​1501:​47
Comment 1 Radar WebKit Bug Importer 2019-01-16 11:41:29 PST 
<rdar://problem/47323967>
Comment 2 Matt Baker 2019-01-16 11:42:32 PST 
Created attachment 359285 [details]
Patch
Comment 3 Nikita Vasilyev 2019-01-16 13:20:15 PST 
Comment on attachment 359285 [details]
Patch

Looks good. I can't reproduce the exception anymore.
Comment 4 Joseph Pecoraro 2019-01-16 13:39:11 PST 
Comment on attachment 359285 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2019-01-16 14:04:41 PST 
Comment on attachment 359285 [details]
Patch

Clearing flags on attachment: 359285

Committed r240051: <https://trac.webkit.org/changeset/240051>
Comment 6 WebKit Commit Bot 2019-01-16 14:04:42 PST 
All reviewed patches have been landed.  Closing bug.