| Summary: | REGRESSION (r34193): Setting the size of a frame with javascript document.body.row no longer works | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Peer Bremer <peer> | ||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Major | CC: | mitz, mjs, pen | ||||
| Priority: | P1 | Keywords: | InRadar, Regression | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Mac | ||||||
| OS: | OS X 10.5 | ||||||
| URL: | http://www.smilecms.com/webkit/expand_frame.html | ||||||
| Attachments: |
|
||||||
Confirmed as a regression with r34291. Resizing the window to trigger relayout fixes the height. Caused by moving the base class recalcStyle() to the beginning of HTMLFrameSetElement::recalcStyle() in <http://trac.webkit.org/changeset/34193#file15>. *** Bug 20140 has been marked as a duplicate of this bug. *** There is also a redraw problem when a page is reloaded inside a frame set and a div uses an image as a background. Part of the background stays white and does not show the image. Solved when the window is resized. Created attachment 22753 [details]
Call the base class implementation last
Comment on attachment 22753 [details]
Call the base class implementation last
r=me
Fixed in <http://trac.webkit.org/changeset/35690>. |
calling a javascript function: function resizeFrame(contractsetting){ document.body.rows=contractsetting; } or using document.body.rows='100,*'; No longer alters teh existing frame set height. See the example at: http://www.smilecms.com/webkit/expand_frame.html Works with Safari 3.1.1 (4525.18) but not with the latest webkit builds