Bug 193453

Summary: Add allow directive for MTLCompilerService.xpc to PluginProcess and WebContent
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebCore Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Per Arne Vollan
Reported 2019-01-15 10:03:23 PST
It should be added to: PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb WebProcess/com.apple.WebProcess.sb.in
Attachments
Patch (2.51 KB, patch)
2019-01-15 10:05 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (2.50 KB, patch)
2019-01-15 10:12 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2019-01-15 10:03:43 PST
rdar://problem/47268166
Per Arne Vollan
Comment 2 2019-01-15 10:05:36 PST
Created attachment 359170 [details] Patch
Brent Fulgham
Comment 3 2019-01-15 10:06:59 PST
Comment on attachment 359170 [details] Patch Great -- thank you for adding this. It looks like you have some smart quotes, which will break things. Can you please fix?
Brent Fulgham
Comment 4 2019-01-15 10:07:26 PST
Comment on attachment 359170 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359170&action=review > Source/WebKit/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:164 > +(allow mach-lookup (xpc-service-name "com.apple.MTLCompilerServiceâ)) You've got a "â" as the closing quote. > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:194 > +(allow mach-lookup (xpc-service-name "com.apple.MTLCompilerServiceâ)) Ditto > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:613 > +(allow mach-lookup (xpc-service-name "com.apple.MTLCompilerServiceâ)) Ditto
Per Arne Vollan
Comment 5 2019-01-15 10:12:24 PST
Created attachment 359172 [details] Patch
Per Arne Vollan
Comment 6 2019-01-15 10:13:06 PST
(In reply to Brent Fulgham from comment #3) > Comment on attachment 359170 [details] > Patch > > Great -- thank you for adding this. > > It looks like you have some smart quotes, which will break things. Can you > please fix? Ah, good catch! I have updated the patch. Thanks for reviewing!
Brent Fulgham
Comment 7 2019-01-15 11:05:58 PST
Comment on attachment 359172 [details] Patch Looks great. r=me!
WebKit Commit Bot
Comment 8 2019-01-15 11:34:18 PST
Comment on attachment 359172 [details] Patch Clearing flags on attachment: 359172 Committed r239994: <https://trac.webkit.org/changeset/239994>
WebKit Commit Bot
Comment 9 2019-01-15 11:34:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.