Bug 193453

Summary: Add allow directive for MTLCompilerService.xpc to PluginProcess and WebContent
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebCore Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Per Arne Vollan 2019-01-15 10:03:23 PST 
It should be added to:

PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in
Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 
WebProcess/com.apple.WebProcess.sb.in
Comment 1 Per Arne Vollan 2019-01-15 10:03:43 PST 
rdar://problem/47268166
Comment 2 Per Arne Vollan 2019-01-15 10:05:36 PST 
Created attachment 359170 [details]
Patch
Comment 3 Brent Fulgham 2019-01-15 10:06:59 PST 
Comment on attachment 359170 [details]
Patch

Great -- thank you for adding this.

It looks like you have some smart quotes, which will break things. Can you please fix?
Comment 4 Brent Fulgham 2019-01-15 10:07:26 PST 
Comment on attachment 359170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359170&action=review

> Source/WebKit/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:164
> +(allow mach-lookup (xpc-service-name "com.apple.MTLCompilerServiceâ))

You've got a "â" as the closing quote.

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:194
> +(allow mach-lookup (xpc-service-name "com.apple.MTLCompilerServiceâ))

Ditto

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:613
> +(allow mach-lookup (xpc-service-name "com.apple.MTLCompilerServiceâ))

Ditto
Comment 5 Per Arne Vollan 2019-01-15 10:12:24 PST 
Created attachment 359172 [details]
Patch
Comment 6 Per Arne Vollan 2019-01-15 10:13:06 PST 
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 359170 [details]
> Patch
> 
> Great -- thank you for adding this.
> 
> It looks like you have some smart quotes, which will break things. Can you
> please fix?

Ah, good catch! I have updated the patch. Thanks for reviewing!
Comment 7 Brent Fulgham 2019-01-15 11:05:58 PST 
Comment on attachment 359172 [details]
Patch

Looks great. r=me!
Comment 8 WebKit Commit Bot 2019-01-15 11:34:18 PST 
Comment on attachment 359172 [details]
Patch

Clearing flags on attachment: 359172

Committed r239994: <https://trac.webkit.org/changeset/239994>
Comment 9 WebKit Commit Bot 2019-01-15 11:34:20 PST 
All reviewed patches have been landed.  Closing bug.