Bug 193444

Summary: [SOUP] Remove usage of NetworkProcess::singleton()
Product: WebKit Reporter: Claudio Saavedra <csaavedra>
Component: WebKitGTKAssignee: Claudio Saavedra <csaavedra>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, basuke, bugs-noreply, mcatanzaro, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mcatanzaro: review+

Claudio Saavedra
Reported 2019-01-15 06:20:04 PST
[SOUP] Remove usage of NetworkProcess::singleton()
Attachments
Patch (4.10 KB, patch)
2019-01-15 06:20 PST, Claudio Saavedra 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Claudio Saavedra
Comment 1 2019-01-15 06:20:32 PST
Created attachment 359158 [details] Patch
Alex Christensen
Comment 2 2019-01-15 16:37:23 PST
http://trac.webkit.org/r240019 This is a step in the right direction. Thanks! We should still move the soup things from NetworkProcessCreationParameters to NetworkSessionCreationParameters, and keep in mind the WebsiteDataStoreParameters member of NetworkProcessCreationParameters is going to eventually be detached.
Alex Christensen
Comment 3 2019-01-15 16:39:27 PST
Also, is GTK still using anything in LegacyCustomProtocolManager? It would be great if we could remove that.
Michael Catanzaro
Comment 4 2019-01-15 19:36:15 PST
That's used in webkitWebContextStartLoadingCustomProtocol and webkitWebContextStopLoadingCustomProtocol in WebKitWebContext.cpp. It's also used in WebKitCustomProtocolManagerClient.[cpp,h], but I guess that class probably disappears if LegacyCustomProtocolManager is removed. I think those are the only places. Not sure how much effort to replace, though; there's a lot of code in LegacyCustomProtocolManagerSoup. Worth a separate bug report to sort this out.
Note You need to log in before you can comment on or make changes to this bug.