Summary: | [SOUP] Remove usage of NetworkProcess::singleton() | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Claudio Saavedra <csaavedra> | ||||
Component: | WebKitGTK | Assignee: | Claudio Saavedra <csaavedra> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, Basuke.Suzuki, bugs-noreply, mcatanzaro, webkit-bug-importer | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Claudio Saavedra
2019-01-15 06:20:04 PST
Created attachment 359158 [details]
Patch
http://trac.webkit.org/r240019 This is a step in the right direction. Thanks! We should still move the soup things from NetworkProcessCreationParameters to NetworkSessionCreationParameters, and keep in mind the WebsiteDataStoreParameters member of NetworkProcessCreationParameters is going to eventually be detached. Also, is GTK still using anything in LegacyCustomProtocolManager? It would be great if we could remove that. That's used in webkitWebContextStartLoadingCustomProtocol and webkitWebContextStopLoadingCustomProtocol in WebKitWebContext.cpp. It's also used in WebKitCustomProtocolManagerClient.[cpp,h], but I guess that class probably disappears if LegacyCustomProtocolManager is removed. I think those are the only places. Not sure how much effort to replace, though; there's a lot of code in LegacyCustomProtocolManagerSoup. Worth a separate bug report to sort this out. |