Bug 193406

Summary: webkitpy: Expose device_type from host-like objects
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, ews-watchlist, glenn, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=192162
Attachments:
Description Flags
Patch none

Jonathan Bedard
Reported 2019-01-14 12:51:00 PST
Platform devices define a device_type. Conceptually, device_type is relevant for other machines as well. Given that we would like to support device specific expectations, it makes sense for host objects to expose information about device type.
Attachments
Patch (17.37 KB, patch)
2019-01-14 12:55 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-01-14 12:51:29 PST
<rdar://problem/47262305>
Jonathan Bedard
Comment 2 2019-01-14 12:55:44 PST
Created attachment 359070 [details] Patch
Jonathan Bedard
Comment 3 2019-01-14 12:57:08 PST
Note that this is for <https://bugs.webkit.org/show_bug.cgi?id=192162>
WebKit Commit Bot
Comment 4 2019-01-14 14:02:24 PST
Comment on attachment 359070 [details] Patch Clearing flags on attachment: 359070 Committed r239945: <https://trac.webkit.org/changeset/239945>
WebKit Commit Bot
Comment 5 2019-01-14 14:02:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.