Summary: | Make the scrolling code use "Async" instead of "Coordinated" | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> | ||||||
Component: | UI Events | Assignee: | Frédéric Wang (:fredw) <fred.wang> | ||||||
Status: | NEW --- | ||||||||
Severity: | Normal | CC: | ews-watchlist | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Frédéric Wang (:fredw)
2019-01-14 03:02:25 PST
Created attachment 359024 [details]
Patch
Attachment 359024 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 359036 [details]
Patch
This is WIP, but I'm not sure what difference we make between 'coordinated' and 'async'. It seems most of the 'coordinated' operations actually assume a scrolling tree (hence are 'async' scrolling) except maybe the m_legacyScrollingLayerCoordinator->registerAllViewportConstrainedLayers calls.
@smfr: Do you think we could actually merge AsyncScrollingCoordinator into ScrollingCoordinator?
Comment on attachment 359036 [details]
Patch
Patch is likely bitrotten, but just asking for review in order to get some feedback and so that we don't forget about it.
Comment on attachment 359036 [details]
Patch
mmh, it seems there are too many rebase conflicts here... It would probably be easier to start the patch again from scratch.
|