Bug 193384

Summary: Web Inspector: Event breakpoints: typing uppercase "DOM" doesn't show completions for events that start with "DOM"
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Nikita Vasilyev
Reported 2019-01-12 16:21:01 PST
Steps: 1. Add an event breakpoint 2. Type "DOM" Expected: Completion shows events that start with "DOM", e.g. "DOMActivate", "DOMCharacterDataModified", and etc. Actual: No completion is shown. Notes: Typing lowercase "dom" shows events that start with "DOM".
Attachments
Patch (1.69 KB, patch)
2019-01-12 19:23 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-01-12 19:23:28 PST
Created attachment 358999 [details] Patch
Nikita Vasilyev
Comment 2 2019-01-14 13:13:51 PST
Comment on attachment 358999 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358999&action=review > Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.js:109 > + if (eventName.toLowerCase().startsWith(this._domEventNameInputElement.value.toLowerCase())) This fixes the bug! I'd r+ 👍
Joseph Pecoraro
Comment 3 2019-01-14 14:56:20 PST
Comment on attachment 358999 [details] Patch r=me
WebKit Commit Bot
Comment 4 2019-01-14 15:22:52 PST
Comment on attachment 358999 [details] Patch Clearing flags on attachment: 358999 Committed r239955: <https://trac.webkit.org/changeset/239955>
WebKit Commit Bot
Comment 5 2019-01-14 15:22:54 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-01-14 15:23:28 PST
<rdar://problem/47267836>
Note You need to log in before you can comment on or make changes to this bug.