Summary: | [LFC] Block/InlinFormattingContext should take Block/InlineFormattingState | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
zalan
2019-01-12 12:44:49 PST
Created attachment 358995 [details]
Patch
Comment on attachment 358995 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358995&action=review > Source/WebCore/layout/FormattingContext.h:-68 > - FormattingState& formattingState() const; I think you could also keep this as-is (and keep m_formattingState private). You can override a function with a more specific return type in the subclass: BlockFormattingState& formattingState() const { return downcast<BlockFormattingState>(FormattingContext::formattingState()); } Committed r239903: <https://trac.webkit.org/changeset/239903> |