Bug 193372

Summary: [JSC] Do not use asArrayModes() with Structures because it discards TypedArray information
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, guijemont, guijemont+jsc-armv7-ews, keith_miller, mark.lam, msaboff, rniwa, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
WIP
none
WIP
none
WIP
none
Archive of layout-test-results from ews100 for mac-highsierra
none
Archive of layout-test-results from ews106 for mac-highsierra-wk2
none
Archive of layout-test-results from ews113 for mac-highsierra
none
Archive of layout-test-results from ews125 for ios-simulator-wk2
none
Patch
none
Patch
none
Patch saam: review+

Yusuke Suzuki
Reported 2019-01-11 17:37:12 PST
...
Attachments
WIP (39.87 KB, patch)
2019-01-11 18:19 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
WIP (41.27 KB, patch)
2019-01-11 18:51 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
WIP (41.27 KB, patch)
2019-01-11 19:41 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
WIP (39.81 KB, patch)
2019-01-11 19:45 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-highsierra (836.64 KB, application/zip)
2019-01-11 20:47 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (1.34 MB, application/zip)
2019-01-11 20:54 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews113 for mac-highsierra (622.76 KB, application/zip)
2019-01-11 20:59 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (1003.27 KB, application/zip)
2019-01-11 21:33 PST, EWS Watchlist 		no flags
Details
Patch (39.77 KB, patch)
2019-01-12 14:47 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (45.85 KB, patch)
2019-01-13 00:54 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (44.96 KB, patch)
2019-01-13 01:18 PST, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-01-11 17:41:56 PST
<rdar://problem/46221750>
Yusuke Suzuki
Comment 2 2019-01-11 18:19:41 PST
Created attachment 358969 [details] WIP
Yusuke Suzuki
Comment 3 2019-01-11 18:51:53 PST
Created attachment 358971 [details] WIP
Yusuke Suzuki
Comment 4 2019-01-11 19:41:32 PST
Created attachment 358975 [details] WIP
Yusuke Suzuki
Comment 5 2019-01-11 19:45:55 PST
Created attachment 358976 [details] WIP
EWS Watchlist
Comment 6 2019-01-11 20:47:13 PST
Comment on attachment 358976 [details] WIP Attachment 358976 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10721775 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 7 2019-01-11 20:47:15 PST
Created attachment 358978 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
EWS Watchlist
Comment 8 2019-01-11 20:54:30 PST
Comment on attachment 358976 [details] WIP Attachment 358976 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10721782 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 9 2019-01-11 20:54:31 PST
Created attachment 358979 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
EWS Watchlist
Comment 10 2019-01-11 20:59:20 PST
Comment on attachment 358976 [details] WIP Attachment 358976 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10721764 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 11 2019-01-11 20:59:21 PST
Created attachment 358980 [details] Archive of layout-test-results from ews113 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-highsierra Platform: Mac OS X 10.13.6
EWS Watchlist
Comment 12 2019-01-11 21:33:43 PST
Comment on attachment 358976 [details] WIP Attachment 358976 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10721830 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 13 2019-01-11 21:33:45 PST
Created attachment 358983 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Yusuke Suzuki
Comment 14 2019-01-12 14:47:27 PST
Created attachment 358996 [details] Patch WIP
Yusuke Suzuki
Comment 15 2019-01-13 00:54:06 PST
Created attachment 359003 [details] Patch
Yusuke Suzuki
Comment 16 2019-01-13 01:18:07 PST
Created attachment 359004 [details] Patch
Yusuke Suzuki
Comment 17 2019-01-13 01:22:13 PST
ArrayProfiling fix is checked by existing JSTests/stress/typed-array-get-by-val-profiling.js
Saam Barati
Comment 18 2019-01-14 14:12:30 PST
Comment on attachment 359004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359004&action=review r=me > Source/JavaScriptCore/bytecode/ArrayProfile.cpp:41 > +const ArrayModes TypedArrayModes[NumberOfTypedArrayTypesExcludingDataView] = { Should "TypedArrayModes" should be capitalized according to our style guidelines?
Yusuke Suzuki
Comment 19 2019-01-14 14:29:41 PST
Comment on attachment 359004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359004&action=review >> Source/JavaScriptCore/bytecode/ArrayProfile.cpp:41 >> +const ArrayModes TypedArrayModes[NumberOfTypedArrayTypesExcludingDataView] = { > > Should "TypedArrayModes" should be capitalized according to our style guidelines? "typedArrayModes" seems nice. Fixed.
Yusuke Suzuki
Comment 20 2019-01-14 14:31:22 PST
Committed r239951: <https://trac.webkit.org/changeset/239951>
Note You need to log in before you can comment on or make changes to this bug.