Bug 193372 – [JSC] Do not use asArrayModes() with Structures because it discards TypedArray information

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Yusuke Suzuki]

...

[Yusuke Suzuki]

<rdar://problem/46221750>

[Yusuke Suzuki]

Created attachment 358969 [details]
WIP

[Yusuke Suzuki]

Created attachment 358971 [details]
WIP

[Yusuke Suzuki]

Created attachment 358975 [details]
WIP

[Yusuke Suzuki]

Created attachment 358976 [details]
WIP

[EWS Watchlist]

Comment on attachment 358976 [details]
WIP

Attachment 358976 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10721775

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 358978 [details]
Archive of layout-test-results from ews100 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 358976 [details]
WIP

Attachment 358976 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10721782

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 358979 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 358976 [details]
WIP

Attachment 358976 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/10721764

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 358980 [details]
Archive of layout-test-results from ews113 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 358976 [details]
WIP

Attachment 358976 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10721830

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 358983 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Yusuke Suzuki]

Created attachment 358996 [details]
Patch

WIP

[Yusuke Suzuki]

Created attachment 359003 [details]
Patch

[Yusuke Suzuki]

Created attachment 359004 [details]
Patch

[Yusuke Suzuki]

ArrayProfiling fix is checked by existing JSTests/stress/typed-array-get-by-val-profiling.js

[Saam Barati]

Comment on attachment 359004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359004&action=review

r=me

> Source/JavaScriptCore/bytecode/ArrayProfile.cpp:41
> +const ArrayModes TypedArrayModes[NumberOfTypedArrayTypesExcludingDataView] = {

Should "TypedArrayModes" should be capitalized according to our style guidelines?

[Yusuke Suzuki]

Comment on attachment 359004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359004&action=review

>> Source/JavaScriptCore/bytecode/ArrayProfile.cpp:41
>> +const ArrayModes TypedArrayModes[NumberOfTypedArrayTypesExcludingDataView] = {
> 
> Should "TypedArrayModes" should be capitalized according to our style guidelines?

"typedArrayModes" seems nice. Fixed.

[Yusuke Suzuki]

Committed r239951: <https://trac.webkit.org/changeset/239951>