Bug 193370

Summary:

Compile out Web API Statistics Collection

Product:

WebKit

Reporter:

John Wilander <wilander>

Component:

WebKit Misc.

Assignee:

John Wilander <wilander>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, cdumez, commit-queue, dbates, ews-watchlist, japhet, keith_miller, mark.lam, msaboff, saam, tsavell, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=187773

Attachments:

Description	Flags
Patch	none

Description John Wilander 2019-01-11 15:24:22 PST

Web API Statistics Collection is not ready and thus should not affect what's processed and saved in the ResourceLoadStatistics data model.

Comment 1 John Wilander 2019-01-11 15:24:43 PST

<rdar://problem/45388584>

Comment 2 John Wilander 2019-01-11 15:52:19 PST

Created attachment 358957 [details]
Patch

Comment 3 Brent Fulgham 2019-01-11 16:13:48 PST

Comment on attachment 358957 [details]
Patch

Ah, great! Thank you for taking care of this. r=me

Comment 4 John Wilander 2019-01-11 16:17:41 PST

Thanks for the review, Brent! I'll wait for green bubbles before landing.

Comment 5 John Wilander 2019-01-11 16:46:02 PST

mac-debug failing tests are unrelated.

Comment 6 WebKit Commit Bot 2019-01-11 17:13:39 PST

Comment on attachment 358957 [details]
Patch

Clearing flags on attachment: 358957

Committed r239888: <https://trac.webkit.org/changeset/239888>

Comment 7 WebKit Commit Bot 2019-01-11 17:13:41 PST

All reviewed patches have been landed.  Closing bug.

Comment 8 Truitt Savell 2019-01-14 08:59:47 PST

It looks like the changes in https://trac.webkit.org/changeset/239888/webkit has caused 5 API tests to fail. 3 are failing on release and 5 are failing on debug.

Build:
https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK1%20%28Tests%29/builds/7194

Log:
https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK2%20%28Tests%29/builds/6210/steps/run-api-tests/logs/stdio

The tests seem to be failing to open a database

Example:
TestWebKitAPI.WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
        
        /Volumes/Data/slave/highsierra-debug/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:140
        Expected equality of these values:
          [getNextMessage().body UTF8String]
            Which is: "Exception: ReferenceError: Can't find variable: openDatabase"
          "Exception: QuotaExceededError: The quota has been exceeded."

Comment 9 John Wilander 2019-01-14 09:42:27 PST

These API tests may very well be for this exact feature. I’ll have a look today.

Comment 10 John Wilander 2019-01-14 11:16:11 PST

I've now run these API tests on my machine with the changes in the patch and they pass. Additionally, they are unrelated to the code change.

Comment 11 Truitt Savell 2019-01-14 16:48:02 PST

After getting a repro case and bisecting the revisions I found 239888 to not be at fault here.

Comment 12 John Wilander 2019-01-14 16:49:02 PST

Thanks, Truitt.