Bug 193369

Summary: Fix style CFNetworkSPI style checker warnings from r239698
Product: WebKit Reporter: Devin Rousso <hi>
Component: WebKit Misc.Assignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, hi, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Devin Rousso 2019-01-11 15:11:05 PST 
<https://webkit.org/b/191539#c36>:
    ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:214:  Misplaced OS version check. Please use a named macro in wtf/Platform.h or wtf/FeatureDefines.h.  [build/version_check] [5]
    ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:94:  Misplaced OS version check. Please use a named macro in wtf/Platform.h or wtf/FeatureDefines.h.  [build/version_check] [5]
    ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:134:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
    ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:661:  Misplaced OS version check. Please use a named macro in wtf/Platform.h or wtf/FeatureDefines.h.  [build/version_check] [5]
Comment 1 Devin Rousso 2019-01-11 15:12:53 PST 
Created attachment 358954 [details]
Patch
Comment 2 Joseph Pecoraro 2019-01-11 15:24:16 PST 
Comment on attachment 358954 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2019-01-11 16:40:20 PST 
Comment on attachment 358954 [details]
Patch

Clearing flags on attachment: 358954

Committed r239884: <https://trac.webkit.org/changeset/239884>
Comment 4 WebKit Commit Bot 2019-01-11 16:40:22 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-01-11 16:41:28 PST 
<rdar://problem/47224762>