Bug 193362

Summary:

webkitpy: Support alternate simctl device list output

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, commit-queue, ews-watchlist, glenn, lforschler, ryanhaddad, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	lforschler: review+

Jonathan Bedard

Reported 2019-01-11 13:45:04 PST

There are a few different variations of simctl device list outputs, we should support them.

Attachments
Patch (1.91 KB, patch) 2019-01-11 13:52 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (1.86 KB, patch) 2019-01-11 14:11 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (1.45 KB, patch) 2019-01-14 13:20 PST, Jonathan Bedard	lforschler: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Jonathan Bedard

Comment 1 2019-01-11 13:45:21 PST

<rdar://problem/47122965>

Jonathan Bedard

Comment 2 2019-01-11 13:52:24 PST

Created attachment 358939 [details] Patch

Lucas Forschler

Comment 3 2019-01-11 14:07:33 PST

Comment on attachment 358939 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358939&action=review > Tools/Scripts/webkitpy/xcode/simulated_device.py:137 > + for devices_for_runtime in simctl_json['devices']: it seems strange to set devices_for_runtime to an empty list, then use it as an iterator here?

Jonathan Bedard

Comment 4 2019-01-11 14:11:08 PST

Created attachment 358945 [details] Patch

Jonathan Bedard

Comment 5 2019-01-11 14:12:17 PST

(In reply to Lucas Forschler from comment #3) > Comment on attachment 358939 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=358939&action=review > > > Tools/Scripts/webkitpy/xcode/simulated_device.py:137 > > + for devices_for_runtime in simctl_json['devices']: > > it seems strange to set devices_for_runtime to an empty list, then use it as > an iterator here? Surprised this code worked! Just uploaded a patch to fix it.

WebKit Commit Bot

Comment 6 2019-01-11 14:48:21 PST

Comment on attachment 358945 [details] Patch Clearing flags on attachment: 358945 Committed r239878: <https://trac.webkit.org/changeset/239878>

WebKit Commit Bot

Comment 7 2019-01-11 14:48:23 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 8 2019-01-11 14:49:28 PST

<rdar://problem/47221502>

Jonathan Bedard

Comment 9 2019-01-14 13:20:45 PST

Reopening to attach new patch.