| Summary: | Make "Disable Web SQL" on by default | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sihui Liu <sihui_liu> | ||||||
| Component: | New Bugs | Assignee: | Sihui Liu <sihui_liu> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, ggaren, tsavell, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 193451 | ||||||||
| Attachments: |
|
||||||||
|
Description
Sihui Liu
2019-01-11 11:15:05 PST
Created attachment 358915 [details]
Patch
Comment on attachment 358915 [details]
Patch
r=me
Comment on attachment 358915 [details] Patch Clearing flags on attachment: 358915 Committed r239885: <https://trac.webkit.org/changeset/239885> All reviewed patches have been landed. Closing bug. I found that the changes in https://trac.webkit.org/changeset/239885/webkit has caused 2 API failure and 1 Timeout on Mac. Log: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20%28Tests%29/builds/10386/steps/run-api-tests/logs/stdio Confirmed this using command: run-api-tests --no-build --debug --root debug-239885 I got these failures with a spade with 239885 but none with 239884. (In reply to Truitt Savell from comment #6) > I found that the changes in https://trac.webkit.org/changeset/239885/webkit > > has caused 2 API failure and 1 Timeout on Mac. > > Log: > https://build.webkit.org/builders/ > Apple%20High%20Sierra%20Release%20WK1%20%28Tests%29/builds/10386/steps/run- > api-tests/logs/stdio > > Confirmed this using command: > run-api-tests --no-build --debug --root debug-239885 > > I got these failures with a spade with 239885 but none with 239884. This failure should be harmless. We can either remove the WebSQL part or enable WebSQL in TestRunner. Can we change the API tests to explicitly enable WebSQL when they run? (In reply to Geoffrey Garen from comment #8) > Can we change the API tests to explicitly enable WebSQL when they run? We have (In reply to Geoffrey Garen from comment #8) > Can we change the API tests to explicitly enable WebSQL when they run? Yes, we can Created attachment 359112 [details]
Fix tests
(In reply to Sihui Liu from comment #10) > Created attachment 359112 [details] > Fix tests Patch cannot be tested after bug is closed... Fix in https://bugs.webkit.org/show_bug.cgi?id=193451 |