Summary: | webkitpy: Print abbreviated baseline search path that includes only folders that exist | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||||||
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | aakash_jain, ap, commit-queue, ews-watchlist, glenn, lforschler, ryanhaddad, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Jonathan Bedard
2019-01-11 09:06:11 PST
Created attachment 358901 [details]
Patch
Comment on attachment 358901 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358901&action=review > Tools/ChangeLog:3 > + webkitpy: Print abbreviated baseline search path that includes only folders that exists Typo: Should be 'exist', not 'exists' > Tools/Scripts/webkitpy/layout_tests/views/printing.py:85 > + full_baseline_search_paths = self._port.baseline_search_path() For consistency, I think this should be 'full_baseline_search_path'. > Tools/Scripts/webkitpy/layout_tests/views/printing.py:88 > + self._print_default('Verbose baseline search paths: {} -> generic'.format(' -> '.join(normalize_baseline(full_baseline_search_paths)))) Again, 'path' not 'paths'. Created attachment 358903 [details]
Patch
Created attachment 358904 [details]
Patch
Comment on attachment 358904 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358904&action=review > Tools/Scripts/webkitpy/layout_tests/views/printing.py:86 > + normalize_baseline = lambda basline_search_paths: [fs.relpath(x, self._port.layout_tests_dir()).replace("../", "") for x in basline_search_paths] typo: basline Created attachment 358909 [details]
Patch for landing
Committed r239874: <https://trac.webkit.org/changeset/239874> |