Bug 193352

Summary: webkitpy: Print abbreviated baseline search path that includes only folders that exist
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, ews-watchlist, glenn, lforschler, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2019-01-11 09:06:11 PST
Maciej mentioned this idea in passing, I think it's a good one given how long our baseline search paths have gotten (and the fact the impending device-specific expectations will likely make this problem worse).
Attachments
Patch (3.36 KB, patch)
2019-01-11 09:10 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (3.36 KB, patch)
2019-01-11 09:40 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (3.35 KB, patch)
2019-01-11 09:49 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.35 KB, patch)
2019-01-11 10:45 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-01-11 09:06:33 PST
<rdar://problem/47210736>
Jonathan Bedard
Comment 2 2019-01-11 09:10:51 PST
Created attachment 358901 [details] Patch
Ryan Haddad
Comment 3 2019-01-11 09:33:53 PST
Comment on attachment 358901 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358901&action=review > Tools/ChangeLog:3 > + webkitpy: Print abbreviated baseline search path that includes only folders that exists Typo: Should be 'exist', not 'exists' > Tools/Scripts/webkitpy/layout_tests/views/printing.py:85 > + full_baseline_search_paths = self._port.baseline_search_path() For consistency, I think this should be 'full_baseline_search_path'. > Tools/Scripts/webkitpy/layout_tests/views/printing.py:88 > + self._print_default('Verbose baseline search paths: {} -> generic'.format(' -> '.join(normalize_baseline(full_baseline_search_paths)))) Again, 'path' not 'paths'.
Jonathan Bedard
Comment 4 2019-01-11 09:40:19 PST
Created attachment 358903 [details] Patch
Jonathan Bedard
Comment 5 2019-01-11 09:49:48 PST
Created attachment 358904 [details] Patch
Lucas Forschler
Comment 6 2019-01-11 10:29:14 PST
Comment on attachment 358904 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358904&action=review > Tools/Scripts/webkitpy/layout_tests/views/printing.py:86 > + normalize_baseline = lambda basline_search_paths: [fs.relpath(x, self._port.layout_tests_dir()).replace("../", "") for x in basline_search_paths] typo: basline
Jonathan Bedard
Comment 7 2019-01-11 10:45:06 PST
Created attachment 358909 [details] Patch for landing
Jonathan Bedard
Comment 8 2019-01-11 14:25:35 PST
Committed r239874: <https://trac.webkit.org/changeset/239874>
Note You need to log in before you can comment on or make changes to this bug.