Bug 193334

Summary: DeviceID hash salt manager can be NULL
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebRTCAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Eric Carlson
Reported 2019-01-10 13:32:45 PST
The websiteDataStore.deviceIdHashSaltStorage NULL check in UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame is in the wrong place.
Attachments
Patch (2.30 KB, patch)
2019-01-10 13:38 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (9.99 KB, patch)
2019-01-10 15:05 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (11.04 KB, patch)
2019-01-10 15:22 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2019-01-10 13:33:11 PST
<rdar://problem/47179650>
Eric Carlson
Comment 2 2019-01-10 13:38:05 PST
Created attachment 358825 [details] Patch
youenn fablet
Comment 3 2019-01-10 13:51:00 PST
Comment on attachment 358825 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358825&action=review > Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:464 > + return; Can we make websiteDataStore return a reference?
Eric Carlson
Comment 4 2019-01-10 15:05:31 PST
Created attachment 358841 [details] Patch
youenn fablet
Comment 5 2019-01-10 15:09:17 PST
Comment on attachment 358841 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358841&action=review > Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:459 > + return; Do we need that check here?
Eric Carlson
Comment 6 2019-01-10 15:22:06 PST
Created attachment 358842 [details] Patch
Eric Carlson
Comment 7 2019-01-10 15:23:05 PST
Comment on attachment 358841 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358841&action=review >> Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:459 >> + return; > > Do we need that check here? It is inside of an asynchronous completion handler, so I assume it is possible for the page to have been invalidated.
WebKit Commit Bot
Comment 8 2019-01-10 16:49:31 PST
Comment on attachment 358842 [details] Patch Clearing flags on attachment: 358842 Committed r239850: <https://trac.webkit.org/changeset/239850>
WebKit Commit Bot
Comment 9 2019-01-10 16:49:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.