Bug 193331

Summary: Web Inspector: incorrect type signature used for protocol enums in async command results
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Blaze Burg
Reported 2019-01-10 12:29:54 PST
Oops.
Attachments
Patch (8.58 KB, patch)
2019-01-10 12:56 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-01-10 12:47:19 PST
Can you give an example?
Blaze Burg
Comment 2 2019-01-10 12:56:01 PST
Created attachment 358822 [details] Patch
EWS Watchlist
Comment 3 2019-01-10 12:59:36 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Devin Rousso
Comment 4 2019-01-10 13:17:50 PST
Comment on attachment 358822 [details] Patch r=me, as you said "Oops." :P
WebKit Commit Bot
Comment 5 2019-01-10 14:37:05 PST
Comment on attachment 358822 [details] Patch Clearing flags on attachment: 358822 Committed r239846: <https://trac.webkit.org/changeset/239846>
WebKit Commit Bot
Comment 6 2019-01-10 14:37:06 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-01-10 14:38:29 PST
<rdar://problem/47190946>
Note You need to log in before you can comment on or make changes to this bug.