Summary: | [macOS] Add name of IORegistry key in sandbox. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||
Component: | WebCore Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, jer.noble, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Per Arne Vollan
2019-01-10 09:44:22 PST
We should allow both to support new WebKit on older OS. Created attachment 358801 [details]
Patch
Comment on attachment 358801 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358801&action=review I don't think this is right. > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:251 > + (iokit-property-regex #"^IOGVA(BGRAEnc|Codec|EncoderRestricted|Scaler|HEVCDecodeCapabilities)") This will cause this to break if someone runs STP on an older OS.. I think this should be: (iokit-property-regex #"^IOGVA(BGRAEnc|Codec|EncoderRestricted|Scaler|VTCapabilities|HEVCDecodeCapabilities)") Created attachment 358802 [details]
Patch
(In reply to Brent Fulgham from comment #3) > Comment on attachment 358801 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=358801&action=review > > I don't think this is right. > > > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:251 > > + (iokit-property-regex #"^IOGVA(BGRAEnc|Codec|EncoderRestricted|Scaler|HEVCDecodeCapabilities)") > > This will cause this to break if someone runs STP on an older OS.. > > I think this should be: > > (iokit-property-regex > #"^IOGVA(BGRAEnc|Codec|EncoderRestricted|Scaler|VTCapabilities|HEVCDecodeCapa > bilities)") Ah, right! I have updated the patch. Thanks for reviewing! Comment on attachment 358802 [details]
Patch
Looks good!
Comment on attachment 358802 [details] Patch Clearing flags on attachment: 358802 Committed r239834: <https://trac.webkit.org/changeset/239834> All reviewed patches have been landed. Closing bug. |