Bug 193324

Summary: [macOS] Add name of IORegistry key in sandbox.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebCore Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Per Arne Vollan
Reported 2019-01-10 09:44:22 PST
IOGVAVTCapabilities key has been changed to IOGVAHEVCDecodeCapabilities.
Attachments
Patch (1.43 KB, patch)
2019-01-10 09:48 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (1.44 KB, patch)
2019-01-10 10:04 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2019-01-10 09:47:09 PST
We should allow both to support new WebKit on older OS.
Per Arne Vollan
Comment 2 2019-01-10 09:48:48 PST
Created attachment 358801 [details] Patch
Brent Fulgham
Comment 3 2019-01-10 10:02:21 PST
Comment on attachment 358801 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358801&action=review I don't think this is right. > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:251 > + (iokit-property-regex #"^IOGVA(BGRAEnc|Codec|EncoderRestricted|Scaler|HEVCDecodeCapabilities)") This will cause this to break if someone runs STP on an older OS.. I think this should be: (iokit-property-regex #"^IOGVA(BGRAEnc|Codec|EncoderRestricted|Scaler|VTCapabilities|HEVCDecodeCapabilities)")
Per Arne Vollan
Comment 4 2019-01-10 10:04:18 PST
Created attachment 358802 [details] Patch
Per Arne Vollan
Comment 5 2019-01-10 10:05:29 PST
(In reply to Brent Fulgham from comment #3) > Comment on attachment 358801 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=358801&action=review > > I don't think this is right. > > > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:251 > > + (iokit-property-regex #"^IOGVA(BGRAEnc|Codec|EncoderRestricted|Scaler|HEVCDecodeCapabilities)") > > This will cause this to break if someone runs STP on an older OS.. > > I think this should be: > > (iokit-property-regex > #"^IOGVA(BGRAEnc|Codec|EncoderRestricted|Scaler|VTCapabilities|HEVCDecodeCapa > bilities)") Ah, right! I have updated the patch. Thanks for reviewing!
Brent Fulgham
Comment 6 2019-01-10 10:08:53 PST
Comment on attachment 358802 [details] Patch Looks good!
WebKit Commit Bot
Comment 7 2019-01-10 10:47:50 PST
Comment on attachment 358802 [details] Patch Clearing flags on attachment: 358802 Committed r239834: <https://trac.webkit.org/changeset/239834>
WebKit Commit Bot
Comment 8 2019-01-10 10:47:51 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-01-10 10:49:29 PST
<rdar://problem/47182898>
Note You need to log in before you can comment on or make changes to this bug.