Bug 193319

Summary: [WPE] API test gardening
Product: WebKit Reporter: Charlie Turner <cturner>
Component: WPE WebKitAssignee: Charlie Turner <cturner>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, loic.yhuel, mcatanzaro, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Charlie Turner 2019-01-10 07:19:25 PST 
[WPE] API test gardening
Comment 1 Charlie Turner 2019-01-10 08:35:41 PST 
Created attachment 358796 [details]
Patch
Comment 2 Loïc Yhuel 2019-01-10 10:44:29 PST 
Comment on attachment 358796 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358796&action=review

> Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:85
> +#if PLATFORM(WIN) || U_ICU_VERSION_MAJOR_NUM >= 58

U_ICU_VERSION_MAJOR_NUM >= 59
ICU 58 has the old UChar definition.
Comment 3 Michael Catanzaro 2019-01-10 12:04:43 PST 
The ICU change should be split into a different bug.
Comment 4 Charlie Turner 2019-01-10 12:42:25 PST 
Created attachment 358819 [details]
Patch

Split the ICU fix into a separate patch, this one now deals only with newly passing API tests on WPE
Comment 5 Charlie Turner 2019-01-10 12:52:44 PST 
Please see https://bugs.webkit.org/show_bug.cgi?id=193332 for the ICU stuff splitted out
Comment 6 Charlie Turner 2019-01-14 04:02:43 PST 
Created attachment 359028 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2019-01-14 04:41:07 PST 
Comment on attachment 359028 [details]
Patch for landing

Clearing flags on attachment: 359028

Committed r239922: <https://trac.webkit.org/changeset/239922>
Comment 8 WebKit Commit Bot 2019-01-14 04:41:09 PST 
All reviewed patches have been landed.  Closing bug.