Bug 193296

Summary: Pipe cache quota request from Network Process to UIProcess
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, cgarcia, commit-queue, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 193323    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

youenn fablet
Reported 2019-01-09 13:55:27 PST
Pipe cache quota request from Network Process to UIProcess
Attachments
Patch (27.34 KB, patch)
2019-01-09 14:37 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (28.23 KB, patch)
2019-01-09 16:18 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (28.27 KB, patch)
2019-01-09 16:24 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (28.82 KB, patch)
2019-01-10 09:04 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (18.07 KB, patch)
2019-01-16 15:10 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-01-09 14:37:52 PST
Created attachment 358740 [details] Patch
youenn fablet
Comment 2 2019-01-09 16:18:34 PST
Created attachment 358762 [details] Patch
youenn fablet
Comment 3 2019-01-09 16:24:47 PST
Created attachment 358763 [details] Patch
youenn fablet
Comment 4 2019-01-10 09:04:15 PST
Created attachment 358800 [details] Patch
youenn fablet
Comment 5 2019-01-10 11:15:17 PST
Comment on attachment 358800 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358800&action=review > Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.h:97 > + void notifyCachesOfRequestSpaceEnd(); I might use notifyRequestSpaceCompleted instead.
Alex Christensen
Comment 6 2019-01-15 14:11:07 PST
Comment on attachment 358800 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358800&action=review Can we test this? > Source/WebKit/NetworkProcess/NetworkProcess.cpp:1382 > + parentProcessConnection()->send(Messages::NetworkProcessProxy::RequestCacheStorageSpace(sessionID, requestIdentifier, origin, quota, currentSize, spaceRequired), 0); This seems like a prime candidate for sendWithAsyncReply
youenn fablet
Comment 7 2019-01-15 14:17:26 PST
(In reply to Alex Christensen from comment #6) > Comment on attachment 358800 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=358800&action=review > > Can we test this? Not yet, https://bugs.webkit.org/attachment.cgi?id=358810&action=review is adding the test along with the callback to the app. > > > Source/WebKit/NetworkProcess/NetworkProcess.cpp:1382 > > + parentProcessConnection()->send(Messages::NetworkProcessProxy::RequestCacheStorageSpace(sessionID, requestIdentifier, origin, quota, currentSize, spaceRequired), 0); > > This seems like a prime candidate for sendWithAsyncReply I can look at that.
youenn fablet
Comment 8 2019-01-16 15:10:49 PST
Created attachment 359318 [details] Patch
WebKit Commit Bot
Comment 9 2019-01-16 17:16:13 PST
Comment on attachment 359318 [details] Patch Clearing flags on attachment: 359318 Committed r240099: <https://trac.webkit.org/changeset/240099>
WebKit Commit Bot
Comment 10 2019-01-16 17:16:14 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2019-01-16 17:17:29 PST
<rdar://problem/47335783>
Note You need to log in before you can comment on or make changes to this bug.