Bug 193284

Summary: Web Inspector: Protocol Logging: log messages as objects if inspector^2 is open
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2019-01-09 09:20:10 PST
I find that having to sift through the mountain of text that arises from protocol logging inside inspector^2 is a torturous task, so I think it's reasonable to say that if we have a way to display a nicer UI, we should. If inspector^2 is closed, stringify all messages. If inspector^2 is open, keep them as JSON objects so they appear all nice and pretty inside inspector^2.
Attachments
Patch (4.66 KB, patch)
2019-01-09 09:23 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-01-09 09:23:21 PST
Created attachment 358710 [details] Patch
Joseph Pecoraro
Comment 2 2019-01-09 11:09:47 PST
Comment on attachment 358710 [details] Patch r=me
WebKit Commit Bot
Comment 3 2019-01-09 11:38:52 PST
Comment on attachment 358710 [details] Patch Clearing flags on attachment: 358710 Committed r239779: <https://trac.webkit.org/changeset/239779>
WebKit Commit Bot
Comment 4 2019-01-09 11:38:54 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-01-09 11:39:28 PST
<rdar://problem/47153013>
Note You need to log in before you can comment on or make changes to this bug.