Bug 193261

Summary: Create a WebResourceLoadStatisticsStore attached to the NetworkSession
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 193199, 193297    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch achristensen: review+, bfulgham: commit-queue+

Brent Fulgham
Reported 2019-01-08 15:23:17 PST
Each NetworkSession should have a WebResourceLoadStatisticsStore that tracks loads for that session.
Attachments
Patch (40.87 KB, patch)
2019-01-09 14:30 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (43.04 KB, patch)
2019-01-09 14:51 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (43.26 KB, patch)
2019-01-09 16:12 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (42.83 KB, patch)
2019-01-09 17:18 PST, Brent Fulgham 		achristensen: review+
bfulgham: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-01-09 14:18:42 PST
<rdar://problem/47158616>
Brent Fulgham
Comment 2 2019-01-09 14:30:09 PST
Created attachment 358738 [details] Patch
Brent Fulgham
Comment 3 2019-01-09 14:51:21 PST
Created attachment 358746 [details] Patch
Brent Fulgham
Comment 4 2019-01-09 16:12:42 PST
Created attachment 358760 [details] Patch
Brent Fulgham
Comment 5 2019-01-09 17:12:45 PST
I've got some test crashes. Fixing now and will upload a patch shortly.
Brent Fulgham
Comment 6 2019-01-09 17:18:35 PST
Created attachment 358769 [details] Patch
Alex Christensen
Comment 7 2019-01-09 17:19:41 PST
Comment on attachment 358760 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358760&action=review The object ownership model seems good. > Source/WebKit/ChangeLog:14 > + WebsiteData object. WebsiteDataStore > Source/WebKit/ChangeLog:18 > + are called in addition the calls to the WebSiteData object. These redundant calls WebsiteDataStore
Alex Christensen
Comment 8 2019-01-09 18:57:15 PST
Comment on attachment 358769 [details] Patch Interesting. This makes it so it can exist in either process, with a future patch that will remove its ability to be in the UIProcess. Cool.
Brent Fulgham
Comment 9 2019-01-09 19:28:57 PST
Committed r239816: <https://trac.webkit.org/changeset/239816>
Brent Fulgham
Comment 10 2019-01-09 20:16:02 PST
Follow-up build fix landed: Committed r239817: <https://trac.webkit.org/changeset/239817>
Note You need to log in before you can comment on or make changes to this bug.